Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type package for certifi #629

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Use type package for certifi #629

merged 1 commit into from
Nov 30, 2022

Conversation

michaeloliverx
Copy link
Member

@michaeloliverx michaeloliverx commented Nov 30, 2022 •
edited
Loading

Use third party type package for certify, types-certify from typeshed https://github.com/python/typeshed/tree/main/stubs/certifi.

Refs #618 #514

@michaeloliverx michaeloliverx marked this pull request as ready for review November 30, 2022 14:43
tomchristie
tomchristie approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, yup.

Can we do the same for trio? - https://github.com/python-trio/trio-typing

@michaeloliverx
Copy link
Member Author

Can we do the same for trio? - https://github.com/python-trio/trio-typing

Sure thing, I didn't realise they shipped types.

@michaeloliverx michaeloliverx merged commit dfeabb4 into encode:master Nov 30, 2022
@michaeloliverx michaeloliverx deleted the use-certifi-types branch November 30, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeloliverx @tomchristie