Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary comprehensions #632

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Remove unnecessary comprehensions #632

merged 1 commit into from
Nov 30, 2022

Conversation

michaeloliverx
Copy link
Member

@michaeloliverx michaeloliverx commented Nov 30, 2022 •
edited
Loading

Use generators instead of comprehensions.

@michaeloliverx
Copy link
Member Author

Seen some code clean-up opportunities while working on the typing stuff so will open a few random PRs to group work.

@michaeloliverx michaeloliverx marked this pull request as ready for review November 30, 2022 17:42
@michaeloliverx michaeloliverx removed the request for review from tomchristie November 30, 2022 17:43
@michaeloliverx michaeloliverx merged commit 52e6832 into encode:master Nov 30, 2022
@michaeloliverx michaeloliverx deleted the remove-unecessary-comprehensions branch November 30, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert graingert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeloliverx @graingert