Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing docs #1011

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

yeraydiazdiaz
Copy link
Contributor

Closes #936

docs/contributing.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
Copy link
Member

@jcugat jcugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I can approve but LGTM 👍

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🥇

@florimondmanca
Copy link
Member

@jcugat Would you be keen to join @encode/maintainers? No expectations, but you'd be able to approve PRs and move them to a mergeable state — extra eyes and reducing the bus factor is always great. :-) What do others think?

@jcugat
Copy link
Member

jcugat commented May 31, 2020

I'm still making my way through all the code, but sure, I'll try to give a hand where I can 🙂

@florimondmanca
Copy link
Member

Hmm, doesn't look like I can add members to the team. @tomchristie Any chance you can help out?

Yeray Diaz Diaz and others added 4 commits June 2, 2020 10:28
Co-authored-by: Josep Cugat <jcugat@gmail.com>
Co-authored-by: Josep Cugat <jcugat@gmail.com>
Co-authored-by: Josep Cugat <jcugat@gmail.com>
@yeraydiazdiaz yeraydiazdiaz merged commit 3196be9 into encode:master Jun 2, 2020
@yeraydiazdiaz yeraydiazdiaz deleted the update-contributing-docs branch June 2, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI troubleshooting section in docs
3 participants