Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent multidict methods #1089

Merged
merged 5 commits into from
Jul 31, 2020
Merged

Conversation

tomchristie
Copy link
Member

Nice sensible symmetry and expected behaviours across each of the following...

  • Headers.get
  • Headers.get_list
  • Headers.items
  • Headers.multi_items
  • QueryParams.get
  • QueryParams.get_list
  • QueryParams.items
  • QueryParams.multi_items

The following have been renamed, but the synonyms remain, and are now pending deprecation...

  • Headers.getlist() -> Headers.get_list()
  • QueryParams.getlist() -> QueryParams.get_list()

@tomchristie tomchristie added this to the v0.14 milestone Jul 27, 2020
@tomchristie tomchristie mentioned this pull request Jul 27, 2020
11 tasks
@tomchristie tomchristie added the user-experience Ensuring that users have a good experience using the library label Jul 27, 2020
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

httpx/_models.py Outdated Show resolved Hide resolved
httpx/_models.py Outdated Show resolved Hide resolved
tomchristie and others added 3 commits July 31, 2020 11:28
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-experience Ensuring that users have a good experience using the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants