Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Headers.update to correctly handle repeated headers #2038

merged 6 commits into from Jan 21, 2022


Copy link

These two tests were failing beforehand

Copy link

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a little while to convince myself, but yes.
Very nice, thank you @adriangb.

@tomchristie tomchristie changed the title bug: fix Headers.update to correctly handle repeated headers Fix Headers.update to correctly handle repeated headers Jan 21, 2022
Copy link

Retitled issue very slightly for neatness & consistency.
We may as well avoid "prefix:" kinda styles.

@adriangb adriangb merged commit 321d4aa into encode:master Jan 21, 2022
5 checks passed
@adriangb adriangb deleted the fix-repeated-headers branch January 21, 2022 16:35
@tomchristie tomchristie mentioned this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants