Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'deploy' environment. #2040

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add 'deploy' environment. #2040

merged 2 commits into from
Jan 24, 2022

Conversation

tomchristie
Copy link
Member

Switch the "publish" workflow to run on the "deploy" environment, so that we can require admin-reviews before deploying to PyPI.

I've also:

  • Setup a deploy environment in this repo's settings.
  • Configured it to have "required reviews" from the @encode/operations team (just me right now).
  • Created a new PyPI API token for httpx.
  • Saved that token in the deploy environment's secrets as PYPI_TOKEN.

We'll want to push a minor release at some point soonish so we can check this all runs okay.

See also encode/httpcore#487 (Let's just try this out with httpcore/httpx to get started)

@tomchristie tomchristie merged commit 31944b9 into master Jan 24, 2022
@tomchristie tomchristie deleted the add-deploy-environment branch January 24, 2022 12:14
@tomchristie
Copy link
Member Author

Fab. Looking forward to seeing this in practice on the next release.
(Hopefully not missed anything...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants