-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always rewind files on multipart uploads. #2065
Conversation
Waiting on a release of Edit Okay, done. Test suite prior to the fix fails with this...
|
@@ -158,9 +157,8 @@ def render_data(self) -> typing.Iterator[bytes]: | |||
yield self._data | |||
return | |||
|
|||
if self._consumed: # pragma: nocover | |||
if hasattr(self.file, "seek"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a question, so we do seek
for the first file upload too, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
It works like charm now! Thanks |
Raised in #2064