-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop EOL Python 3.6 #2097
Drop EOL Python 3.6 #2097
Conversation
Only @tomchristie can run the pipeline, right? |
@Kludex Shouldn't be the case, not sure why the pipeline didn't get triggered again after the merge. 🤔 |
Here we go… I undid the merge and rebased. Not sure what happened. @ofek You might need to reset your |
CI fails, need to upgrade |
I think this happens because the pipeline listens to master's CI configuration file. 🤔 |
That's misleading. But that's not a blocker for this PR. |
|
@tomchristie Would you mind triggering the CI with that button below? |
@ofek - I'm not sure what you mean? The CI has run okay for this. |
I pressed the button 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Approved on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on my line of reasoning here #2136 (reply in thread)
(Is it new that PRs from first-time contributors must be approved to run each time? Is that a new GitHub thing? Configurable perhaps?) |
It's been a thing for a while. I believe it's to stop spam bots from mining crypto and stuff like that. A common trick for a well known contributor like @ofek is for them to just a no-brainer PR (like taking the removal of trailing whitespaces they're doing in this PR) which one of us can instantly approve and merge, making them no longer a first time contributor -> they can run CI on a more complicated PR like this one |
y'all go for it, team. |
Not configurable yet. |
Discussion: #2136
Also, now
uvicorn
can be bumped (was pinned to fix Python 3.6 in #1807)