Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EOL Python 3.6 #2097

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Drop EOL Python 3.6 #2097

merged 5 commits into from
Mar 30, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 26, 2022

Discussion: #2136

Also, now uvicorn can be bumped (was pinned to fix Python 3.6 in #1807)

@Kludex
Copy link
Member

Kludex commented Mar 26, 2022

Only @tomchristie can run the pipeline, right?

@florimondmanca
Copy link
Member

@Kludex Shouldn't be the case, not sure why the pipeline didn't get triggered again after the merge. 🤔

@florimondmanca
Copy link
Member

Here we go… I undid the merge and rebased. Not sure what happened. @ofek You might need to reset your py branch if you need to access it again.

@florimondmanca
Copy link
Member

CI fails, need to upgrade mkdocs due to mkdocs/mkdocs#2799

@Kludex
Copy link
Member

Kludex commented Mar 28, 2022

@Kludex Shouldn't be the case, not sure why the pipeline didn't get triggered again after the merge. 🤔

I think this happens because the pipeline listens to master's CI configuration file. 🤔

@Kludex Kludex requested a review from tomchristie March 28, 2022 15:20
@Kludex
Copy link
Member

Kludex commented Mar 28, 2022

Discussion: #2136

Also, now uvicorn can be bumped (was pinned to fix Python 3.6 in #1807)

That's misleading. uvicorn was not pinned because of 3.6. But because of another issue: encode/uvicorn#1161

But that's not a blocker for this PR.

@ofek
Copy link
Contributor Author

ofek commented Mar 29, 2022

black needs upgrading psf/black#2966

@Kludex Kludex mentioned this pull request Mar 29, 2022
@ofek
Copy link
Contributor Author

ofek commented Mar 30, 2022

@tomchristie Would you mind triggering the CI with that button below?

@tomchristie
Copy link
Member

@ofek - I'm not sure what you mean? The CI has run okay for this.

@Kludex
Copy link
Member

Kludex commented Mar 30, 2022

I pressed the button 😅

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Approved on my end.

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on my line of reasoning here #2136 (reply in thread)

@florimondmanca
Copy link
Member

(Is it new that PRs from first-time contributors must be approved to run each time? Is that a new GitHub thing? Configurable perhaps?)

@adriangb
Copy link
Member

It's been a thing for a while. I believe it's to stop spam bots from mining crypto and stuff like that. A common trick for a well known contributor like @ofek is for them to just a no-brainer PR (like taking the removal of trailing whitespaces they're doing in this PR) which one of us can instantly approve and merge, making them no longer a first time contributor -> they can run CI on a more complicated PR like this one

@tomchristie
Copy link
Member

y'all go for it, team.

@Kludex
Copy link
Member

Kludex commented Mar 30, 2022

(Is it new that PRs from first-time contributors must be approved to run each time? Is that a new GitHub thing? Configurable perhaps?)

Not configurable yet.

This was referenced May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants