Drop private imports from test_decoders.py #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
commented
Feb 4, 2023
| decoder = TextChunker(chunk_size=3) | ||
| assert decoder.decode("123456") == ["123", "456"] | ||
| assert decoder.decode("78") == [] | ||
| assert decoder.flush() == ["78"] |
There was a problem hiding this comment.
Most of these cases we actually already well covered in test_responses.py, so I figured I'd expand those a bit to match coverage, and drop these.
tomchristie
reviewed
Feb 9, 2023
There was a problem hiding this comment.
Good stuff. I notice that this change will conflict with #2423.
Any opinion on which of those two PRs we should merge first?
|
Does the new GitHub feature (merge queue) helps here? |
|
I'm happy to update this once #2423 is merged 😃 |
|
okay - this one needs updating now. |
tomchristie
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another contribution towards #2492