Parametrize tests with concurrency backend #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
test/backend-fixture
branch
3 times, most recently
from
fc53532
to
e8d87aa
Compare
florimondmanca
force-pushed
the
test/backend-fixture
branch
from
e8d87aa
to
4869b9e
Compare
florimondmanca
commented
Aug 24, 2019
sethmlarson
suggested changes
Aug 24, 2019
There was a problem hiding this comment.
To fix the whole "cover the default case" issue let's have a single test-case that tests that when you don't pass a backend it's the AsyncioBackend and that the client is capable of making a request. I think that's sufficient to say that things work fine.
Other than that this looks pretty good to me. :)
|
@sethmlarson Sounds fair — I added a test for the case when we're not specifying a backend. 👍 |
sethmlarson
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
Mostly adds a
backendfixture and use it in the relevant tests, and some refactoring of HTTP/2 and connection pool tests to be more backend-agnostic as well.I'm thinking that now we don't really test the usual path (e.g. not passing a
backendtoAsyncClient). This can be easily fixed by addingNoneas an extra backend to makeAsyncClient& others use their default backend. This increases the duration of the test suite though (~20%?), so… any thoughts?