Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop anyio dependency #3220

Closed
wants to merge 2 commits into from
Closed

Drop anyio dependency #3220

wants to merge 2 commits into from

Conversation

T-256
Copy link
Contributor

@T-256 T-256 commented Jun 11, 2024

It is currently used indirectly by httpcore's asyncio feature.
There is no usage of anyio in httpx's codebase.

It is currently used indirectly by httpcore's _asyncio_ feature.
There is no usage of `anyio` in httpx's codebase/
@rafalkrupinski
Copy link

rafalkrupinski commented Jul 7, 2024

There's some code that tries to use trio and falls back to asyncio, like Event or sleep. Why not use anyio for this? Less code to maintain...

edit:
OK I see there's a process of getting rid of anyio due to its performance penalty.
I'm just gonna link this: agronholm/anyio#736

@T-256
Copy link
Contributor Author

T-256 commented Sep 23, 2024

There's some code that tries to use trio and falls back to asyncio, like Event or sleep. Why not use anyio for this? Less code to maintain...

Can you mention those lines? I think those lines are in httpcore.

OK I see there's a process of getting rid of anyio due to its performance penalty.

No, the main goal of this PR is to correct project specification when published. Since httpx codebase has not anyio then it's wrong to put it in project.dependencies .

@T-256
Copy link
Contributor Author

T-256 commented Sep 24, 2024

solved in #2858

@T-256 T-256 closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants