Remove deprecated 'proxies' parameter. #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
|
I remember I also left the tests. We need to remove them as well. Do you need any help? |
|
Also, I suggest turning on CI for branches that start with 'version-'. |
|
Hrm... either I got #3318 wrong, or else it isn't effecting outstanding PRs. |
We merged it into the master, not version-1.0:) |
T-256
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created
version-1.0branch so that we can incrementally merge 1.0 PRs prior to a release.I'm going to start by issuing some obvious pull requests that remove API that's already been deprecated.
This pull request deals with removing the
proxies=...parameter, which has been deprecated in favor ofproxy=..., withmount=...used for more complex configurations.