Allow using Client in an async environment #513
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508
This is an attempt at handling the situation in which users try to use
httpx.get()
orhttpx.Client()
in an async environment that has a running loop (e.g. in a Jupyter notebook).I documented several potential caveats in the form of code comments.
I still need to verify this actually solves the Jupyter use case, though the tests give me hope that it does. :-)