Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document when to use AsyncClient #534

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Document when to use AsyncClient #534

merged 2 commits into from
Nov 22, 2019

Conversation

florimondmanca
Copy link
Member

@florimondmanca florimondmanca commented Nov 17, 2019 •
edited
Loading

Fixes #179, refs (or fixes?) #508.

Screenshot 2019-11-17 at 11 47 51

@florimondmanca florimondmanca added the docs Changes to the documentation label Nov 17, 2019
yeraydiazdiaz
yeraydiazdiaz approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! 🌟

Just a minor nit otherwise LGTM

docs/async.md Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed Nov 20, 2019
View reviewed changes
docs/async.md Outdated Show resolved Hide resolved
@florimondmanca
Copy link
Member Author

Thanks @tomchristie and @yeraydiazdiaz, sounds legit! Last commit simplifies the write up.

@florimondmanca
Copy link
Member Author

Merging now, thanks! :)

@florimondmanca florimondmanca merged commit 926d6cd into master Nov 22, 2019
@florimondmanca florimondmanca deleted the doc/no-sync-in-async branch November 22, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie left review comments

@yeraydiazdiaz yeraydiazdiaz yeraydiazdiaz approved these changes

@sethmlarson sethmlarson Awaiting requested review from sethmlarson

Assignees
No one assigned
Labels
docs Changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the existing runloop for sync calls in async handler
3 participants
@florimondmanca @tomchristie @yeraydiazdiaz