Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client handles redirect + auth #552

Merged
merged 24 commits into from
Nov 27, 2019
Merged

Conversation

tomchristie
Copy link
Member

Builds on #544

Drops redirect and auth from being middleware, and just handles them on the Client instance.

@tomchristie
Copy link
Member Author

Screenshot 2019-11-26 at 16 05 27

@florimondmanca
Copy link
Member

@tomchristie The only thing itching me on this is that we’re back with having lots of redirect utility helper methods on the Client.

They used to be neatly encapsulated in the middleware class.

Any chance we can keep redirect-as-middleware and the benefits from the refactoring here?

@tomchristie
Copy link
Member Author

I'm not really fussed about it - they're neatly demarked. (In the same way as the merge_<...> methods.)

I'd far rather we have a mostly linear chain of control to follow through, like this.

@tomchristie tomchristie merged commit 00e150f into master Nov 27, 2019
@tomchristie tomchristie deleted the redirect-and-auth-in-client branch November 27, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants