-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client handles redirect + auth #552
Conversation
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
@tomchristie The only thing itching me on this is that we’re back with having lots of redirect utility helper methods on the Client. They used to be neatly encapsulated in the middleware class. Any chance we can keep redirect-as-middleware and the benefits from the refactoring here? |
I'm not really fussed about it - they're neatly demarked. (In the same way as the I'd far rather we have a mostly linear chain of control to follow through, like this. |
Builds on #544
Drops redirect and auth from being middleware, and just handles them on the
Client
instance.