refactor limit #32
Closed
refactor limit #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongweiming can you describe specific cases these changes support or improve? Some code samples of the cases would help a lot. |
|
I did a little looking at Django's limit implementation. While Django doesn't have a limit method and uses a getitem overload to handle to use array slice syntax for limiting, it doesn't produce a new queryset on limit. The supports some of the changes @dongweiming is suggesting in this refactor. @tomchristie, @ryananguiano, what are your thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think use
limit_countas a parameter is the best solution, after that, it might also passoffset,havingand so on, there are too many params@Vector919 @tomchristie please review, thanks!