Add Model and Queryset .all() as_dict support #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blue-hope
commented
Sep 25, 2020
| @@ -285,6 +309,11 @@ def pk(self): | |||
| def pk(self, value): | |||
| setattr(self, self.__pkname__, value) | |||
|
|
|||
| async def as_dict(self): | |||
| return { | |||
| column.name: getattr(self, column.name) for column in self.__table__.columns | |||
There was a problem hiding this comment.
here's class model's new as_dict method
Closed
|
Hello, was this truly implemented? orm 0.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-Is:
ORM model does not support its own dictionary serialize method
To-be:
ORM model can be serialized to dict like this:
await User.objects.get(id=1).as_dict()or Queryset.all() that returns ORM model objects' list can be serialized to dict like this:
await User.objects.all().as_dict()