-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default jinja2
setup.
#196
Comments
Good one. Also I think the templates that we are using for DEBUG mode (500) and in the future 404 should be loaded by Jinja as well. |
So currently the jinja2 package is needed to be installed even if I do not use tempate in my project at all? |
Jinja2 is an optional package and is only required for using the default template configuration |
@Witekkq - It's completely optional. If you set |
I think we probably ought to include a default Jinja2 setup out-of-the box, so...
We'd ensure that the support is strictly optional, and document what a more explicit setup would look like.
This would require:
template_dir=
toStarlette.__init__
and use it to setup a.template_env
attribute.Starlette.get_template()
See our example repo or our template docs for how the template setup should work.
Any feedback on this?
Anyone interested in tacking a crack at it?
The text was updated successfully, but these errors were encountered: