Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix some spelling mistakes #1115

Merged
merged 2 commits into from
Feb 2, 2021
Merged

docs: Fix some spelling mistakes #1115

merged 2 commits into from
Feb 2, 2021

Conversation

jbampton
Copy link
Contributor

No description provided.

jcwilson
jcwilson approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@jcwilson jcwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least this proves I didn't introduce those database test errors in my PRs ;)

@euri10
Copy link
Member

euri10 commented Dec 18, 2020

At the very least this proves I didn't introduce those database test errors in my PRs ;)

nah it comes from us not pinning pytest : pytest-dev/pytest#8055

not sure where the unclosed socket is though, I'd guess in TestClient but not sure

@JayH5 JayH5 changed the title Fix spelling docs: Fix some spelling mistakes Feb 2, 2021
JayH5
JayH5 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@JayH5 JayH5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JayH5 JayH5 merged commit ed73b97 into encode:master Feb 2, 2021
@jbampton jbampton deleted the fix-spelling branch February 7, 2021 15:07
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayH5 JayH5 JayH5 approved these changes

@jcwilson jcwilson jcwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbampton @euri10 @jcwilson @JayH5