Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way this issue could be addressed in Starlette. This basically change the type of the
headers
value forhost
to a marker class that inherits frombytes
(TrustedHost
) once the header is validated byTrustedHostMiddleware
. This may cause compatibility issues with middlewares/applications that expectshost
to be exactlybytes
.There are other approaches this could have been addressed, such as:
scope
, e.g.scope["host_validated"] = "blah.com"
host
against a regex pattern (must only contain characters that are allowed for a domain name), you can still be redirected to an unexpected malicious domain, but at least it would prevent most of the funkier attacksLet me know if you think that another approach should be taken instead.
url_for()
should not trust unvalidated Host header #1855