Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_router to Starlette and Router #2189

Closed
wants to merge 6 commits into from

Conversation

Lancetnik
Copy link

@Lancetnik Lancetnik commented Jun 18, 2023

Summary

It's a PR connected with FastAPI nested lifespan bugfix.
So, there is a raw include_router implementation to inherit it by the FastAPI next step.
Also, it merge all nested by mount applications' events and lifespans to main application (#649).

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Member

Kludex commented Jun 18, 2023

That's really not what I mean. include_router doesn't make sense for Starlette.

We have this related PR: #1988.

@Kludex Kludex closed this Jun 18, 2023
@Lancetnik
Copy link
Author

@Kludex did you talk about run Host routes lifespan calling? Or something else? Can you explain please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants