-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASGI 3 #435
ASGI 3 #435
Conversation
Would need a version bump to 0.12.0. |
@florimondmanca @tiangolo Particularly relevant to you folks. (Are FastAPI and Bocadillo pinned against the current 0.11.x release cycle?) I'll prob. coordinate with responder folks to make the upgrade there, once this is in. |
Big change indeed! But agreed that the simpler interface is worth it. Bocadillo is safe as it has Starlette pinned to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Sorry for the delay and thanks for the ping. Yep, FastAPI is pinned too to |
Okay, we'd best just push on with this. Might roll a |
Refs django/asgiref#78 and django/asgiref#80
In short:
So previously...
Would become more simply, this:
It's a big change to have to make throughout the stack, and about as late in the day as we'd still be able to get away with it, but it'll be worth it for the simpler interface, clearer tracebacks, and easier-to-write applications and middleware classes.
See also encode/uvicorn#325