Hide value for Password fields.

[jhtimmins]

Since the input field has this format:

<input type="password" id="form-contact-e" name="e" required value="">

I added two tests, one for the beginning of the string and one for the end, to get both type and value. How would you feel about moving the value tag to the front of the input so this can be consolidated into one test? This will also make it less brittle against other fields with empty string values.

Closes #30

[tomchristie]

Let's instead have the password test case be on its own, maybe?...

Something like this perhaps?...

def test_password_rendering()
    class PasswordForm(typesystem.Schema):
        password = typesystem.String(format="password")
    form = forms.Form(PasswordForm, values={'password': 'secret'})
    html = str(form)
    assert 'secret' not in html

[tomchristie]

Note that the existing test as it stands is testing the password value, for an unpopulated form. Need to be testing a form with values= set to some input data.

[tomchristie]

Run scripts/lint to resolve any linting issues. https://travis-ci.org/encode/typesystem/jobs/502767667#L322

[jhtimmins]

Ah good catch. I'll make the updates.

…

On Wed, Mar 6, 2019 at 1:00 PM Tom Christie ***@***.***> wrote: Run scripts/lint to resolve any linting issues. https://travis-ci.org/encode/typesystem/jobs/502767667#L322 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEsqNCof4ByiRY-iRiyrB0E0nR1i_ANxks5vUCxTgaJpZM4bhx1X> .

[jhtimmins]

Oops, git mistake. I removed the old test but it didn't get committed. One sec.

[tomchristie]

I've added Closes #30 to the description here, so it'll auto-close once this is merged.

[tomchristie]

Ace, thanks!