Use Python syntax for type hints instead of comments #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This changes all type hints to use modern Python (3.6+) syntax instead of special comments, but leaves the ‘type: ignore’ comments intact. Most of these changes are purely mechanical, except for these: - It seems the _message_dict can only ever contain str and int keys, so make that explicit instead of using `typing.Any`. - The call to `datetime.time(**kwargs, tzinfo=None)` gives mypy warnings which can be avoided by reordering the arguments. Changing it to `datetime.time(tzinfo=None, **kwargs)` will behave the same, since `kwargs` will never contain a `tzinfo` key, because `TIME_REGEX` does not have a capturing group with that name.
|
ping, any chance to get this merged? the branch got out of date but i just resolved the merge conflicts and it now applies cleanly again. |
|
👍 |
|
Good stuff, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all type hints to use modern Python (3.6+) syntax instead
of special comments, but leaves the ‘type: ignore’ comments intact.
Most of these changes are purely mechanical, except for these:
It seems the _message_dict can only ever contain str and int keys,
so make that explicit instead of using
typing.Any.The call to
datetime.time(**kwargs, tzinfo=None)gives mypywarnings which can be avoided by reordering the arguments. Changing
it to
datetime.time(tzinfo=None, **kwargs)will behave the same,since
kwargswill never contain atzinfokey, becauseTIME_REGEXdoes not have a capturing group with that name.