Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused events #1956

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Remove unused events #1956

merged 1 commit into from
Apr 27, 2023

Conversation

JonasKs
Copy link
Contributor

@JonasKs JonasKs commented Apr 26, 2023

Ref #1950, I forgot to remove some unused Event() code in my tests.

@JonasKs
Copy link
Contributor Author

JonasKs commented Apr 26, 2023

@Kludex , some websocket tests randomly failed? 🤔

@Kludex
Copy link
Member

Kludex commented Apr 26, 2023

@Kludex , some websocket tests randomly failed? 🤔

Yes. It's because we use a port that is available, and that makes it flaky. 😢

@Kludex
Copy link
Member

Kludex commented Apr 27, 2023

Thanks @JonasKs 🙏

@Kludex Kludex merged commit 4d302a9 into encode:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasKs @Kludex