Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use IOCP in windows #423

Merged
merged 3 commits into from
Oct 3, 2019
Merged

use IOCP in windows #423

merged 3 commits into from
Oct 3, 2019

Conversation

Copy link
Member

@gvbgduh gvbgduh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be not a bad idea to bring another implementation of the event loop. But in this implementation, it implicitly replaces the asyncio event loop. It may confuse the user it's generally better to keep things explicit.
So for this particular case, it would be better to create a separate module, like uvloop, so it would be possible to specify it with the --loop param running the uvicorn server.

@abersheeran
Copy link
Member Author

I agree it. I will make changes later and resubmit.

@gvbgduh
Copy link
Member

gvbgduh commented Sep 19, 2019

@abersheeran looks really good to me. Let's run it with @tomchristie what he thinks.

@tomchristie
Copy link
Member

Liking it, yup!

@abersheeran
Copy link
Member Author

So, why not merge the PR? What else do I need to modify?

@gvbgduh
Copy link
Member

gvbgduh commented Oct 3, 2019

hey @abersheeran, I'm going to merge it today, but if you could run ./scripts/lint and then push again it would save some time.

@gvbgduh gvbgduh changed the base branch from master to RC-0.9.1 October 3, 2019 00:25
@gvbgduh
Copy link
Member

gvbgduh commented Oct 3, 2019

Actually, never mind!

@gvbgduh gvbgduh merged commit 1b50b13 into encode:RC-0.9.1 Oct 3, 2019
@abersheeran
Copy link
Member Author

I am sorry that I didn't notice lint, I will use it next time. 😅

@gvbgduh
Copy link
Member

gvbgduh commented Oct 3, 2019

all good, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants