Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maximum h11 dependency version to 0.10 #772

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

kmichel2
Copy link
Contributor

@kmichel2 kmichel2 commented Aug 28, 2020

The h11 Changelog for 0.10 only include those items:

The h11 Changelog for 0.10 only include those items:
 - Drop support for Python 3.4.
 - Support Python 3.8.
 - Make error messages returned by match failures less ambiguous (encode#98).
@euri10 euri10 merged commit 54d729c into encode:master Aug 28, 2020
@euri10
Copy link
Member

euri10 commented Aug 28, 2020

thanks @kmichel-sereema

@HarrySky
Copy link

HarrySky commented Sep 28, 2020

@euri10 after 0.12.0 release I can't use uvicorn with httpx==0.15.4:

httpcore 0.11.0 has requirement h11<0.10,>=0.8, but you'll have h11 0.10.0 which is incompatible.

Can h11 version be updated in httpx as well? Should I open an issue somewhere?

@euri10
Copy link
Member

euri10 commented Sep 28, 2020

seems weird to me @HarrySky , I use both pinned at those exact versions 0.12.0 and 0.15.4 with poetry as the dependency manager and had 0 issues but I'm no versioning pro.

edit: on a brand new venv without cache it seems ok to me, what's failing for you ?

❯ python -m venv uvicorn_httpx
❯ source bin/activate
source: no such file or directory: bin/activate
❯ cd uvicorn_httpx
❯ source bin/activate
❯
❯
❯ pip install uvicorn --no-cache-dir
Collecting uvicorn
  Downloading uvicorn-0.12.0-py3-none-any.whl (44 kB)
     |████████████████████████████████| 44 kB 5.2 MB/s
Collecting h11<0.11,>=0.8
  Downloading h11-0.10.0-py2.py3-none-any.whl (53 kB)
     |████████████████████████████████| 53 kB 12.4 MB/s
Collecting click==7.*
  Downloading click-7.1.2-py2.py3-none-any.whl (82 kB)
     |████████████████████████████████| 82 kB 9.3 MB/s
Installing collected packages: h11, click, uvicorn
Successfully installed click-7.1.2 h11-0.10.0 uvicorn-0.12.0
WARNING: You are using pip version 20.1.1; however, version 20.2.3 is available.
You should consider upgrading via the '/home/lotso/uvicorn_httpx/bin/python -m pip install --upgrade pip' command.
❯ pip install httpx --no-cache-dir
Collecting httpx
  Downloading httpx-0.15.4-py3-none-any.whl (65 kB)
     |████████████████████████████████| 65 kB 6.4 MB/s
Collecting certifi
  Downloading certifi-2020.6.20-py2.py3-none-any.whl (156 kB)
     |████████████████████████████████| 156 kB 12.5 MB/s
Collecting sniffio
  Downloading sniffio-1.1.0-py3-none-any.whl (4.5 kB)
Collecting httpcore==0.11.*
  Downloading httpcore-0.11.0-py3-none-any.whl (52 kB)
     |████████████████████████████████| 52 kB 12.6 MB/s
Collecting rfc3986[idna2008]<2,>=1.3
  Downloading rfc3986-1.4.0-py2.py3-none-any.whl (31 kB)
Collecting h11<0.10,>=0.8
  Downloading h11-0.9.0-py2.py3-none-any.whl (53 kB)
     |████████████████████████████████| 53 kB 13.8 MB/s
Collecting idna; extra == "idna2008"
  Downloading idna-2.10-py2.py3-none-any.whl (58 kB)
     |████████████████████████████████| 58 kB 13.4 MB/s
Installing collected packages: certifi, sniffio, h11, httpcore, idna, rfc3986, httpx
  Attempting uninstall: h11
    Found existing installation: h11 0.10.0
    Uninstalling h11-0.10.0:
      Successfully uninstalled h11-0.10.0
Successfully installed certifi-2020.6.20 h11-0.9.0 httpcore-0.11.0 httpx-0.15.4 idna-2.10 rfc3986-1.4.0 sniffio-1.1.0
WARNING: You are using pip version 20.1.1; however, version 20.2.3 is available.
You should consider upgrading via the '/home/lotso/uvicorn_httpx/bin/python -m pip install --upgrade pip' command.
  ~/uvicorn_httpx ❯

@HarrySky
Copy link

I am installing my package that depends on uvicorn==0.12.0 and httpx[http2]==0.15.4, I install them simultaneously, not separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants