Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mypy issues #983

Closed
wants to merge 2 commits into from
Closed

fix: mypy issues #983

wants to merge 2 commits into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Mar 7, 2021

This fixes some mypy issues, but there are still 140 101 to fix (with the current configuration on setup.cfg).

I want to keep working on this and add the mypy to the CI, but I also want a confirmation about: #978 (comment).

EDIT: I'm using the "Starlette types" slightly modified for the time being.

@Kludex Kludex marked this pull request as draft March 8, 2021 03:55
@euri10
Copy link
Member

euri10 commented Mar 8, 2021

ok this is quite a task, in order to simplify things for you and those who're going to review, I'd suggest doing what we begun in https://github.com/encode/uvicorn/pull/751/files ie. add one / two or more related files you want to mypy in setup.cfg then fix the errors.
also as you know types were added to the asgi ref, I've not followed if this was usable in current's state, but let's use that as the baseline,

@Kludex
Copy link
Member Author

Kludex commented Mar 8, 2021

Sure. It works for me.

I'm going to close this PR as it's already too messed up. I'll be opening small PRs over the week.

Thank you :)

@Kludex Kludex closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants