Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all runtime definitions to parachain-commons #40

Closed
3 tasks
clangenb opened this issue Oct 28, 2021 · 2 comments
Closed
3 tasks

Move all runtime definitions to parachain-commons #40

clangenb opened this issue Oct 28, 2021 · 2 comments

Comments

@clangenb
Copy link
Member

clangenb commented Oct 28, 2021

polkadot-v0.9.12 has introduced a new crate that unifies some type and constant definitions. However, we still have the redundant definitions inside the runtime (partly because they are still there in upstream too). We should remove the runtime definitions favoring the ones from the parachain-commons crate and. However, we should re-export them there!

  • remove redundant defintions from runtime
  • extend missing definitions in the parachain-commons
  • re-export all definitions in the both runtimes.
@clangenb
Copy link
Member Author

Not really necessary for the epic, but given the amount of effort I think this is a very nice to have.

@clangenb
Copy link
Member Author

Obsolete since the runtime has been moved to the fellows/runtimes repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant