Fix more typing issues #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rad-cord
approved these changes
May 15, 2023
adam-encord
reviewed
May 15, 2023
encord/http/utils.py
Outdated
| elif orm_class == DicomSeries: | ||
| return "application/dicom" | ||
| else: | ||
| raise RuntimeError(f"Unsupported type `{orm_class}`") |
There was a problem hiding this comment.
This is ValueError I think
There was a problem hiding this comment.
Good catch, thanks!
adam-encord
reviewed
May 15, 2023
| @@ -218,11 +218,23 @@ def ontology_object_to_dict(self, ontology_object: OntologyObject) -> Dict: | |||
| "featureNodeHash": ontology_object.feature_node_hash, | |||
| } | |||
|
|
|||
| def __ontology_classification_options_to_dict( | |||
| self, options: Optional[Iterable[ClassificationOption]] | |||
| ) -> Optional[List[Dict]]: | |||
There was a problem hiding this comment.
Will this ever return None? I don't think so?
sergei-encord
force-pushed
the
fix-more-typing-issues
branch
from
a215936
to
4b609f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.