Add encoding.DescribeResponse #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
DomBlack
previously approved these changes
May 17, 2022
parser/encoding/rpc.go
Outdated
| type ParameterEncoding struct { | ||
| // Location (e.g. header, query, body) where the parameter should be marshalled from/to | ||
| Location ParameterLocation | ||
| // The location specific name of the parameter (e.g. cheeseEater, cheese-eater, X-Cheese-Eater | ||
| Name string | ||
| // Whether the name should be case-sensitive | ||
| CaseSensitive bool |
There was a problem hiding this comment.
When sent to true the standard library JSON (i.e. the one we use in the client generator) will still be case insensitive. Is this ok? (i.e. what's the use case fo having this be true?)
There was a problem hiding this comment.
Good point. I'll remove it
This commit adds a new `DescribeResponse` function to the encoding package. This function's job is to describe the http wire representation of a Response type The output of this function can then be used for both the client generation and for the code generation inside Encore request handlers for applications.
DomBlack
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
DescribeResponsefunction to the encoding package.This function's job is to describe the http wire representation of a Response type
The output of this function can then be used for both the client generation
and for the code generation inside Encore request handlers for applications.