Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-151: Memory issues with Buckets + Refactoring #152

Merged
merged 5 commits into from
Feb 20, 2022

Conversation

Ammar-T
Copy link
Contributor

@Ammar-T Ammar-T commented Feb 20, 2022

Details

  • After making the bucket and list views synched with the board in terms of likes, comments, text changes, there was a bug introduced which led to a lot of listeners being created, which affected everything on the app. The canvas was laggy due to the countless listeners and read/writes happening.
  • This PR removes our original side panel which kept the listeners active even after the panel was closed. I've tried using the ngOnDestroy method however it wouldn't work for the panels. So, instead of having side panels, I moved our bucket and list view into modals which resolved the issue and kept our original functionality.

Smaller Changes:

  • Added small black border to all posts (both canvas and modal posts)
  • Centered "Forgot Password" text on login page
  • Wait for project to load until name and other info is printed (was showing errors in console)
  • Renamed post component classes to differ between fabric and HTML posts
  • Reworked HTML posts to use flexbox for better experience with list/buckets modal

Closes #151

@Ammar-T Ammar-T merged commit 2081c12 into develop Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving posts when having buckets open causes a memory issue
1 participant