feat(mechanics): Separate delayed and non-delayed shield generation and hull repair attributes

[Quantumshark]

Feature

This PR implements the feature requested by Amazinite on the latest Campfire stream

Summary

Rather than delaying all shield/hull regen, shield delay and hull delay now only delay the newly added delayed versions of the attributes.

Screenshots

todo

Usage examples

outfit "Shield Generator That Works Best After Ten Seconds Outside Of Combat"
	"shield generation" .2
	"shield energy" .2
	"delayed shield generation" 4.8
	"delayed shield energy" 4.8
	"shield delay" 600

outfit "Shield Generator That Becomes Less Efficient After Five Seconds Outside Of Combat"
	"shield generation" 1
	"shield energy" 1
	"delayed shield energy" 4
	"shield delay" 300

Testing Done

Confirmed normal regen without delay still works properly.

shield.delay.compressed.mp4

Added

	"shield delay" 120
	"delayed shield generation" 20
	"delayed shield heat" 40

To the medium systems core I was using and flew over my shield-depleting wormhole.

Save File

This save file can be used to test these changes:
todo

Performance Impact

Doubles the number of attribute gets during regen/repair for any ships that use the new attributes.

[TomGoodIdea]

Code-wise looks good.

Btw, what do you think of every generator having its own delay? Or would it be too complicated for players?

[Quantumshark]

Btw, what do you think of every generator having its own delay? Or would it be too complicated for players?

The exact specifics of the data implementation are a question for future PRs. But, as I understand it the intent is that the standard human shield generators would have both regular and delayed generation, so I expect a wide implementation.

[alexrovw]

I guess if you're going to re-implement it like this, the Ka'het Grand Restorer should be modified to have a delayed shield generation attribute of 7.08 and a shield delay of 350. depleted shield delay might need to be grandfathered in anyway to avoid breaking plugins. I don't know.

[Quantumshark]

Depleted shield delay should still work, so no need to replace it with shield delay. But yes, the Ka'het grand restorer probably should be changed to use delayed regen rather than regular regen.

[alexrovw]

Depleted shield delay should still work, so no need to replace it with shield delay.

It doesn't, though. I tested it before making that comment. On master branch, it takes the appropriate ~5 seconds before restoring. After checking out this PR, it restores instantly, even as I am receiving breakthrough hull damage.

I was going to speculate about where in the code the issue is, but I don't fully understand it, so I didn't want to steer you wrong.

[Quantumshark]

Did you change it to use delayed regen rather than the non-delayed regen? Delayed regen should be delayed by both types of delay, and non-delayed regen by neither of them.

[alexrovw]

Did you change it to use delayed regen rather than the non-delayed regen? Delayed regen should be delayed by both types of delay, and non-delayed regen by neither of them.

I didn't make any changes to the data files. Same exact save file for both tests as well. I rebuilt the binary from scratch each time.

[Quantumshark]

Updated the Grand Restorer to use delayed shield generation, which should fix it.

[1010todd]

More reason to quickly implement something like #9025 before we have 50k different attributes for all possible combination of stuffs.

Though, for now I like this. The fact that delayed shield gen also affect other shield gen always bother me whenever I made an outfit with one which often ends up in me not making/using it at all.

Also, is there a way to use the old behavior (one outfit with shield delay will delay shield regen of entire ship) with this? Might be occasionally useful to still have that option.

[alexrovw]

Updated the Grand Restorer to use delayed shield generation, which should fix it.

I'm not necessarily against changing the Grand Restorer to use delayed shield generation, but we might still need to support depleted shield delay and depleted repair delay to avoid breaking plugins. Need a dev to chime in, I suppose.

[Hurleveur]

Looks good to me code wise, cant wait to have the functionality

That said @tibetiroka could you maybe take a look at those tooltips?

[xX-Dillinger-Xx]

Do we know if the plan would be to change existing outfits or create new ones?
My opinion, is if the idea is to address balance issues, then existing outfits should be changed. Adding more outfits, that are similar to what we already have, just adds more confusion for the player. Sometimes, I feel we already have too many outfits. Every time I decide to alter my loadout, I end up going down the rabbit hole comparing every possible combination. I already have way too many sheets of paper, with numbers scribbled all over them, cluttering my desk. On the plus side, my math skills have gotten a good work out.

[tibetiroka]

Tooltips look good.

[TomGoodIdea]

Looks like something went wrong when you were fixing the brackets, let's try again

[Amazinite]

We should also update ShipInfoDisplay to include delayed regen in the stats, as otherwise installing a grand restorer will look like it's doing nothing for your shield regen.

endless-sky/source/ShipInfoDisplay.cpp

Lines 196 to 197 in 5d875d4

	double shieldRegen = attributes.Get("shield generation")
	* (1. + attributes.Get("shield generation multiplier"));

endless-sky/source/ShipInfoDisplay.cpp

Lines 211 to 212 in 5d875d4

	double hullRepair = attributes.Get("hull repair rate")
	* (1. + attributes.Get("hull repair multiplier"));

endless-sky/source/ShipInfoDisplay.cpp

Lines 378 to 389 in 5d875d4

	double shieldEnergy = (hasShieldRegen) ? attributes.Get("shield energy")
	* (1. + attributes.Get("shield energy multiplier")) : 0.;
	double hullEnergy = (hasHullRepair) ? attributes.Get("hull energy")
	* (1. + attributes.Get("hull energy multiplier")) : 0.;
	tableLabels.push_back((shieldEnergy && hullEnergy) ? "shields / hull:" :
	hullEnergy ? "repairing hull:" : "charging shields:");
	energyTable.push_back(Format::Number(-60. * (shieldEnergy + hullEnergy)));
	double shieldHeat = (hasShieldRegen) ? attributes.Get("shield heat")
	* (1. + attributes.Get("shield heat multiplier")) : 0.;
	double hullHeat = (hasHullRepair) ? attributes.Get("hull heat")
	* (1. + attributes.Get("hull heat multiplier")) : 0.;
	heatTable.push_back(Format::Number(60. * (shieldHeat + hullHeat)));