Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless Key App menu links and info needs replacement #71

Closed
jofilizola opened this issue Sep 19, 2023 · 6 comments · Fixed by #113
Closed

Endless Key App menu links and info needs replacement #71

jofilizola opened this issue Sep 19, 2023 · 6 comments · Fixed by #113
Labels
bug Something isn't working

Comments

@jofilizola
Copy link
Contributor

jofilizola commented Sep 19, 2023

The links on the App Menu currently link to Learning Equality's website, not Endless'.

Documentation >
links to https://kolibri.readthedocs.io/en/latest/
should link to https://support.endlessos.org/en/endless-key

Community Forum >
links to https://community.learningequality.org/
should link to: we don't have a forum for Endless Key... We should create an "Endless Key" category in https://community.endlessos.com/ and link to that

About > Website >
links to: https://learningequality.org/
Should link to: https://www.endlessos.org/key

Remove from menu:
"Open Kolibri Home" and "Open in external browser"

@cassidyjames @erikos does that sound good?

@jprvita
Copy link
Contributor

jprvita commented Sep 19, 2023

The links on the App Menu currently link to Learning Equality's website, not Endless'.

Documentation > links to https://kolibri.readthedocs.io/en/latest/ should link to https://support.endlessos.org/en/endless-key

Community Forum > links to https://community.learningequality.org/ should link to: we dont have a forum for ENdless Key... should we link to the Endless OS one? or remove?

We could create a "Endless Key" category in our forum and link to it. As an example, this is how the "Hack" category looks. The one thing to keep in mind is how to monitor / reply to any incoming traffic there. Also, this would be somewhat overlapping with the "Feedback" button, so maybe removing would make more sense, IDK. I guess it depends on whether we want to foster a community of users talking among themselves,in public, vs users only being able to reach us directly, in private.

@cassidyjames
Copy link
Member

cassidyjames commented Sep 20, 2023

I wonder with the in-app links plus the About window supporting much more rich information (and Adwaita recently adding the ability to grab About window information straight from AppStream MetaInfo), could we remove a lot of these from the menu?

We could pursue that upstream and explain that the new About window was explicitly designed to house this kind of information if we wanted. Then it is fewer places to sync information (update it once in the MetaInfo and everywhere else gets the changes), and fewer places for the user to check as well.

I can throw together a mockup/prototype real quick…

@manuq
Copy link
Contributor

manuq commented Sep 20, 2023

@dsd has a good point about removing the "Open Kolibri Home" and "Open in external browser" options from the menu.

@jofilizola
Copy link
Contributor Author

jofilizola commented Sep 20, 2023

@cassidyjames is the idea to remove those links from the menu and add them to the about window? and the info will come from the same source as the flathub info? Localization included? What do we need to do to make that happen?

We could pursue that upstream

Upstream meaning Kolibri?

@cassidyjames
Copy link
Member

@jofilizola

is the idea to remove those links from the menu and add them to the about window? and the info will come from the same source as the flathub info?

Yep, that would make the most sense to me; this is implemented in the latest version of the Adwaita About window, which we should be able to use after #80

Localization included?

Good point, I need to double check this. I would be surprised if it wasn't handled but I'm not 100% sure.

What do we need to do to make that happen?

We'd need Libadwaita 1.4 which is included with GNOME 45. So first we'd want to land #80, then we'd need a PR to update how the About window is constructed; I just did this in my own apps, so I could submit a PR here (but it's straightforward enough; any engineer could). And yeah at the same time we could clean up some other menu entries that aren't really relevant to Key as @manuq and @dsd have pointed out.

Upstream meaning Kolibri?

Yep, it could make sense to move some of this into the About window in Kolibri itself.

@jofilizola
Copy link
Contributor Author

jofilizola commented Sep 22, 2023

This all sounds good to me!
I (think) have updated the links here: https://github.com/endlessm/endless-key-flatpak/blob/main/data/metainfo/org.endlessos.Key.metainfo.xml.in.in

So, actions here would be:

dylanmccall added a commit that referenced this issue Oct 23, 2023
dylanmccall added a commit that referenced this issue Oct 23, 2023
This same information is now available in the About dialog.

Helps: #71
dylanmccall added a commit that referenced this issue Oct 23, 2023
Both "Open in Browser" and "Open Kolibri Home Folder" are considered
unnecessary for the Endless Key app.

Helps: #71
dylanmccall added a commit that referenced this issue Oct 23, 2023
dylanmccall added a commit that referenced this issue Oct 23, 2023
Both "Open in Browser" and "Open Kolibri Home Folder" are considered
unnecessary for the Endless Key app.

Helps: #71
dylanmccall added a commit that referenced this issue Oct 23, 2023
dylanmccall added a commit that referenced this issue Oct 24, 2023
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: #71
dylanmccall added a commit that referenced this issue Oct 24, 2023
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: #71
dylanmccall added a commit that referenced this issue Oct 25, 2023
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: #71
dylanmccall added a commit that referenced this issue Oct 25, 2023
dylanmccall added a commit that referenced this issue Oct 27, 2023
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: endlessm/endless-key-flatpak#71
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: endlessm/endless-key-flatpak#71
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: endlessm/endless-key-flatpak#71
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
In addition, label the support link "Documentation" in the About window,
for consistency.

Helps: endlessm/endless-key-flatpak#71
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants