Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path of favicon.ico is wrong #978

Closed
usta opened this issue Mar 27, 2022 · 33 comments · Fixed by #1900
Closed

path of favicon.ico is wrong #978

usta opened this issue Mar 27, 2022 · 33 comments · Fixed by #1900
Assignees
Labels
bug Something isn't working

Comments

@usta
Copy link
Member

usta commented Mar 27, 2022

https://endoflife.date/favicon.ico doesn't exist and thus it is giving 404
@captn3m0

@usta usta added the bug Something isn't working label Mar 27, 2022
@usta
Copy link
Member Author

usta commented Mar 27, 2022

It try to reach favicon like this :
https://endoflife.date/favicon.ico <-- 404
but favicon.ico 's path is under assets like
https://endoflife.date/assets/favicon.ico

@usta
Copy link
Member Author

usta commented Mar 27, 2022

And looks like this bug exist but we missed it with other 404s :
[this is 2 months ago's logs which you shared ]
image

@usta usta changed the title favicon.ico doesn't exist path of favicon.ico is wrong Mar 27, 2022
@usta
Copy link
Member Author

usta commented Mar 28, 2022

@BiNZGi @captn3m0 ping ?

@captn3m0
Copy link
Member

I'd noticed it, but always thought that our favicon wasn't good enough to be used anywhere, so never got around to fixing it.

We have the image we use on GitHub avatar (I cropped it from https://unsplash.com/photos/mn0Kezx98EI), but I don't like it much either.

Any suggestions?

@usta
Copy link
Member Author

usta commented Mar 28, 2022

i always liked more certain things , it might be much better to use a hourglass because it let you understand it will be finish
when its top part finishes. How about normal clocks ? who know what shows 12 ? what is that will it start ? or will it end ? nothing is certain in that
image
image

@BiNZGi
Copy link
Member

BiNZGi commented Mar 28, 2022

I also agree to create a new icon. The hourglass with all the sand down (cycle ended) can be a first idea. Font Awesome has already an icon for that in their library: https://fontawesome.com/icons/hourglass-end?s=duotone

Because of copyright issues it is probably a good idea to create something by our-self or use a free to use graphic.

@usta
Copy link
Member Author

usta commented Mar 28, 2022

not the all sands down but almost all because otherwise it doest look like a hourgalss but something else when you first look it

@marcwrobel
Copy link
Member

Maybe this one : https://openmoji.org/library/emoji-231B/ or https://openmoji.org/library/emoji-23F3/. Their icons are under the CC BY-SA 4.0 license, so all that's required is an attribution in the projects README and on the generated website (next to This site uses Just the Docs, a documentation theme for Jekyll. ?).

@marcwrobel
Copy link
Member

This issue is linked to #28.

@captn3m0
Copy link
Member

captn3m0 commented Nov 24, 2022

Anyone wants to file a PR for a favicon to start? (With the openmoji icon)

@marcwrobel
Copy link
Member

Sure, I will give it a try.

@captn3m0, I also like the icon you put in the assets directory, it better convey the idea of a "cycle" than an hourglass IMHO :
icon

Where does it come from ?

@captn3m0
Copy link
Member

@marcwrobel
Copy link
Member

Material Icons are under Apache 2 license, so we could use them too I think. But let's do a POC first.

marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used. Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon).

A new section has been added to the README in order to give credits to the softwares used in the project.
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and site.webmanifest were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. site.webmanifest is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 24, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
@marcwrobel
Copy link
Member

I have created two PRs : one with the Openmoji icon (#1900) and the other with the Material icon (#1902).

Each PR update the favicon and add the logo next to the site's title. Let me know what you think of it by looking at the deployed site. Personally I prefer the material icon.

marcwrobel added a commit that referenced this issue Nov 25, 2022
Material's 'update' icon (https://fonts.google.com/icons?selected=Material+Icons+Outlined:update:) was used, as permitted by Google (https://developers.google.com/fonts/faq#can_i_use_the_font_in_a_logo).

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/a/21359390/374236).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of a Material icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 25, 2022
Material's 'update' icon (https://fonts.google.com/icons?selected=Material+Icons+Outlined:update:) was used, as permitted by Google (https://developers.google.com/fonts/faq#can_i_use_the_font_in_a_logo).

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/a/21359390/374236).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of a Material icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 25, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
@marcwrobel
Copy link
Member

@captn3m0, @BiNZGi, any preference between the two logo ?

marcwrobel added a commit that referenced this issue Nov 28, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Nov 28, 2022
Material's 'update' icon (https://fonts.google.com/icons?selected=Material+Icons+Outlined:update:) was used, as permitted by Google (https://developers.google.com/fonts/faq#can_i_use_the_font_in_a_logo).

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/a/21359390/374236).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of a Material icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
@BiNZGi
Copy link
Member

BiNZGi commented Nov 29, 2022

I am not happy with both versions. The hourglass looks dated like from an old OS or something. The reload with the timing pointer is the wrong icon for the site.
I would try another hourglass version, e.g. from https://fontawesome.com/icons/hourglass-half?s=duotone&f=classic

@marcwrobel
Copy link
Member

Unfortunately it's not possible to use fontawesome icons because of their license.

And hourglass material icons are not good too IMHO (https://fonts.google.com/icons?selected=Material+Icons+Outlined:update:&icon. Maybe the bootstrap icon ?

hourglass-split

@marcwrobel
Copy link
Member

I just found those icons who are in the public domain.

https://publicdomainvectors.org/en/free-clipart/Hourglass-vector-graphics/31382.html :
time-clock-publicdomainvectors-org

https://publicdomainvectors.org/en/free-clipart/Simple-hourglass-vector-drawing/12580.html :
sanduhr

Is one of those icon ok @BiNZGi, @usta, @captn3m0 ?

Note that I still think that the Material icon (reload with clock) is the better one, as explained in #978 (comment) 😋.

@captn3m0
Copy link
Member

My vote is for #1902, but not by much. I'm also thinking about the next step - social media images, where I'm thinking of something like the following as a dynamic image for every product to be used for social media shares:

sample k8s summary card image

I think the hourglass works much better here, but I don't like the current version in #1900. Not liking the openclipart options from above either. Clicked through to the original sources:

@marcwrobel
Copy link
Member

OK. One thing is sure, the hourglass is the preferred icon. Il will try to find some alternative icons.

In the mean time, I am closing #1902.

@marcwrobel
Copy link
Member

@captn3m0 ?

@captn3m0
Copy link
Member

I have an idea for adapting the hourglass to our usecase. Will post here in a bit. Probably using the [wikipedia one])(https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg) since that looks the most like an icon,

@marcwrobel
Copy link
Member

Ok, great.

@marcwrobel marcwrobel linked a pull request Dec 22, 2022 that will close this issue
marcwrobel added a commit that referenced this issue Dec 22, 2022
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of an Openmoji icon as this site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
@captn3m0
Copy link
Member

This was the plan, I didn't do a good job of the editing though (The cuts should have been different, it looks like an imposed triangle right now).

eol-favicon

SVG

@marcwrobel
Copy link
Member

I really like what you did. The circle made me think a little bit to the Ubuntu logo (https://logosmarcas.net/wp-content/uploads/2020/11/Ubuntu-Emblema.png) ;).

Let's integrate this logo and see how it looks.

@marcwrobel
Copy link
Member

@captn3m0, are you sure the SVG is the good one ? It is just a black circle when I look at it.

marcwrobel added a commit that referenced this issue Dec 26, 2022
A handmade icon derived from https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

Site logo has been injected before the site name. It has to be done using CSS : the Just the Docs theme does not offer an extension point for doing this.

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated at least by the use of the Wikimedia icon as the site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
@marcwrobel
Copy link
Member

Just gave it a shot following this tutorial : https://www.youtube.com/watch?v=JxIAXqbb5vQ. Got :
logo-192x192

Updated the PR with (https://deploy-preview-1900--endoflife-date.netlify.app/), let me know if it's OK.

@captn3m0
Copy link
Member

SVG opens correctly for me in Firefox, so it should be correct, but your version is better regardless.

I think using the colored variant for Open-Graph, social images etc makes sense, while using a B/W variant for the favicon - I don't quite like the colored variant in the favicon.

Even better would be to have a dual-color SVG favicon that uses white for dark mode: https://blog.tomayac.com/2019/09/21/prefers-color-scheme-in-svg-favicons-for-dark-mode-icons/. Seems to have reasonable support (75% as per CanIUse)

marcwrobel added a commit that referenced this issue Dec 27, 2022
A handmade icon derived from https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg was used.

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

Site logo has been injected before the site name. It has to be done using CSS : the Just the Docs theme does not offer an extension point for doing this.

A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated at least by the use of the Wikimedia icon as the site logo.

Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Dec 27, 2022
A handmade logo, derived from https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg was used. It represents the concepts of time (with the hourglass) and EOL/cycles (with the colored split circle).

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

Site logo has been injected before the site name using CSS. It had to be done that way because the Just the Docs theme does not offer an extension point for doing it.

A new section has been added to the README in order to give credits to the softwares used in the project. The human.txt has been updated too. This is mandated at least by the use of the Wikimedia icon as the site logo.

Note that I would have prefered to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link), but those are slowing down significantly the build (10s -> 40s).
marcwrobel added a commit that referenced this issue Dec 27, 2022
A handmade logo, derived from https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg was used. It represents the concepts of time (with the hourglass) and EOL/cycles (with the colored split circle).

Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390).

New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest).

Site logo has been injected before the site name using CSS. It had to be done that way because the Just the Docs theme does not offer an extension point for doing it.

A new section has been added to the README in order to give credits to the softwares used in the project. The human.txt has been updated too. This is mandated at least by the use of the Wikimedia icon as the site logo.

Note that I would have prefered to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link), but those are slowing down significantly the build (10s -> 40s).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants