Update site logo with an hourglass icon #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcwrobel
force-pushed
the
28-logo-favicon
branch
4 times, most recently
from
086078b
to
32cc876
Compare
captn3m0
reviewed
Nov 24, 2022
captn3m0
reviewed
Nov 24, 2022
|
Any additions to HACKING.md as well perhaps? |
marcwrobel
force-pushed
the
28-logo-favicon
branch
2 times, most recently
from
2d3f6ce
to
7ea3931
Compare
|
@captn3m0, HACKING.md updated. I also injected the logo next to the title (using CSS, no extension point in the jekyll theme for doing it). Do you like it ? |
marcwrobel
force-pushed
the
28-logo-favicon
branch
from
7ea3931
to
f6e6deb
Compare
marcwrobel
changed the title
marcwrobel
changed the title
marcwrobel
changed the title
marcwrobel
force-pushed
the
28-logo-favicon
branch
from
f6e6deb
to
12816be
Compare
usta
changed the title
usta
changed the title
marcwrobel
force-pushed
the
28-logo-favicon
branch
from
12816be
to
a2de50e
Compare
marcwrobel
changed the title
|
The Hourglass icon from Openmoji is not liked by EndOfLife contributors. A new icon must be found. |
This was
linked to
issues
Dec 22, 2022
marcwrobel
force-pushed
the
28-logo-favicon
branch
2 times, most recently
from
d3665b1
to
fda2b09
Compare
|
PR updated with https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg (see #978 (comment)). |
marcwrobel
force-pushed
the
28-logo-favicon
branch
from
fda2b09
to
a474ecc
Compare
captn3m0
approved these changes
Dec 27, 2022
marcwrobel
force-pushed
the
28-logo-favicon
branch
2 times, most recently
from
4d00161
to
4618439
Compare
A handmade logo, derived from https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg was used. It represents the concepts of time (with the hourglass) and EOL/cycles (with the colored split circle). Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/questions/21359342/is-putting-your-favicon-ico-file-in-a-non-root-path-a-bad-idea/21359390#21359390). New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest). Site logo has been injected before the site name using CSS. It had to be done that way because the Just the Docs theme does not offer an extension point for doing it. A new section has been added to the README in order to give credits to the softwares used in the project. The human.txt has been updated too. This is mandated at least by the use of the Wikimedia icon as the site logo. Note that I would have prefered to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link), but those are slowing down significantly the build (10s -> 40s).
marcwrobel
force-pushed
the
28-logo-favicon
branch
from
4618439
to
879c107
Compare
|
OK, great. I fixed a few things ( Will do a final check and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'hourglass not done' icon from Openmoji (https://openmoji.org/library/emoji-23F3/) was used. Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon).
A new section has been added to the README in order to give credits to the softwares used in the project.