Update site logo OPTION 2 [with 'update' Material icon] #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcwrobel
changed the title
marcwrobel
force-pushed
the
28-logo-favicon-2
branch
from
b60612b
to
fb2fc87
Compare
|
@marcwrobel needs a rebase |
|
|
marcwrobel
force-pushed
the
28-logo-favicon-2
branch
from
fb2fc87
to
584ee94
Compare
usta
changed the title
|
My 2 cents is for hour-glass ( option1 ) Let me expain why a refresh like icon is not suitable: |
marcwrobel
changed the title
Material's 'update' icon (https://fonts.google.com/icons?selected=Material+Icons+Outlined:update:) was used, as permitted by Google (https://developers.google.com/fonts/faq#can_i_use_the_font_in_a_logo). Derived icons for various usage were generated using https://realfavicongenerator.net/ (from the SVG icon). All icons were placed in the 'assets' directory, except favicon.ico. The theme mandates its path to be /favicon.ico, and it seems a lot of browsers assume this location anyway (https://stackoverflow.com/a/21359390/374236). New files, browserconfig.xml and manifest.json were also added. It is not clear if browserconfig.xml is still useful (https://webmasters.stackexchange.com/q/131077) but it does not hurt. manifest.json is useful for PWA (https://developer.mozilla.org/en-US/docs/Web/Manifest). A new section has been added to the README in order to give credits to the softwares used in the project. This is mandated by at least the use of a Material icon as this site logo. Note that I would have prefer to use the 'link' tag to generate image URLs (https://jekyllrb.com/docs/liquid/tags/#link). But those are slowing down significantly the build (10s -> 40s).
It has to be done using CSS : the Just the Docs theme does not offer an extension point for doing this.
marcwrobel
force-pushed
the
28-logo-favicon-2
branch
from
584ee94
to
0d4b02f
Compare
|
PR abandoned : see #978 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1900, but with the original logo.