fix: "x" parameter in many tests is optional #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
changed the title
This was referenced Jan 14, 2024
dckc
approved these changes
Jan 14, 2024
Fixed PR comment. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: Agoric/agoric-sdk#8745
Description
At Agoric/agoric-sdk#8745 (comment) @dckc noticed that an optional
xparameter should have been declared optional but was not. Turns out that I had copy-paste-modify that mistaken declaration to other tests.This PR fixes the ones in endo. Agoric/agoric-sdk#8750 the ones in agoric-sdk
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
more accurate static types should help us generate more accurate docs
Testing Considerations
none
Upgrade Considerations
none