refactor(bundle-source): Node.js conditions #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
help me find the ci log of the test running, plz? |
dckc
approved these changes
Jul 23, 2024
|
Looks like I’ve got some ironing to do. |
kriskowal
force-pushed
the
kriskowal-conditions
branch
from
4c188a3
to
1edf2ee
Compare
kriskowal
force-pushed
the
kriskowal-conditions
branch
from
1edf2ee
to
7e516a0
Compare
kriskowal
added a commit
that referenced
this pull request
Jul 25, 2024
## Description From `bundle-source`, a bundle cannot currently take on a dependency on any of the packages entrained by `devDependencies` in the `package.json` of the entry package. This change (indirectly) enables a bundle to capture dev dependencies by providing the flag `--condition development` from the [`-C` flag introduced in #2373](#2373) ### Security Considerations None. ### Scaling Considerations None. ### Documentation Considerations - NEWS - README - USAGE ### Testing Considerations Existing tests adjusted to exercise the new condition instead of the explicit `dev` flag. ### Compatibility Considerations Backward-compatibility verified by running tests before and after switching from the explicit `dev` flag to a `development` condition in the compartment mapper. No integration test provided, but can be manually verified by bundling a package that relies on a devDependency and providing `-C development`. ### Upgrade Considerations None.
kriskowal
added a commit
that referenced
this pull request
Jul 30, 2024
#2389) Refs: #2388 ## Description See #2388, we cannot at this time change the schema of `compartment-map.json` as I attempted in #2373 ### Security Considerations None. ### Scaling Considerations None. ### Documentation Considerations None. ### Testing Considerations None. ### Compatibility Considerations Restores backward compatibility for production systems. The file `app.agar` is a zip file generated by a previous version of the compartment mapper, used as a test fixture to verify that future versions can import ancient versions. To get tests passing in #2373, I regenerated `app.agar` and in this change, I revert it to the original schema. Having to regenerate `app.agar` is supposed to be a hint that something is broken, and I waltzed through the warnings. ### Upgrade Considerations None.
kriskowal
added a commit
that referenced
this pull request
Jul 30, 2024
#2389) Refs: #2388 See #2388, we cannot at this time change the schema of `compartment-map.json` as I attempted in #2373 None. None. None. None. Restores backward compatibility for production systems. The file `app.agar` is a zip file generated by a previous version of the compartment mapper, used as a test fixture to verify that future versions can import ancient versions. To get tests passing in #2373, I regenerated `app.agar` and in this change, I revert it to the original schema. Having to regenerate `app.agar` is supposed to be a hint that something is broken, and I waltzed through the warnings. None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The upcoming release was planned to introduce a
-t,--tagsflag to thebundle-sourcecommand. I’ve found that the analogous flag in the Node.js CLI is-C,--conditionand elected to take this opportunity to make these consistent, before releasing the new feature.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
Usage docs update. Not yet documented in README.
Testing Considerations
Covered with a CLI test.
Compatibility Considerations
This feature is not yet released, so the change to
bundle-sourcehas no compatibility concerns.The change to
@endo/compartment-mapperdeprecates thetagsoption to all functions and aliasesconditionsfor backward-compatibility.Upgrade Considerations
None.