feat(bundle-source): Support JSON modules in nestedEvaluate and getExport #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-json-modules-script
branch
from
be0f972
to
a0729e8
Compare
kriskowal
force-pushed
the
kriskowal-json-modules-script
branch
from
6ef2aa7
to
46aa954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds JSON module support to nestedEvaluate and getExport on par with endoScript format. This augments the existing integration fixture for endoScript format to cover JSON support and then adds parity tests.
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None. The absence, not presence, of this support is usually surprising.
Testing Considerations
Additional coverage for our older formats.
Compatibility Considerations
Increases parity between bundle formats.
Upgrade Considerations
None.