Replace rust-crypto crate #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure we are using up to date and maintained dependencies, this commit removes rust-crypto as it's no longer maintained and replaces it with aes_gcm. Additionally it updates a few tests for clarity of what we are testing. Finally, it simplifies the public api of FileEncryption. It removes the initialization vector and additional authenticated data from encrypt. This is to ensure compatibility with existing encrypted secrets already generated elsewhere. The initialization vector passed in was unused and it generated it's own internally.
This commit removes a println! statement from the test_encryption_fails_with_non_hex_key test.
This commit changes some of the docs related to general usage of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure we are using up to date and maintained dependencies, this commit removes rust-crypto as it's no longer maintained and replaces it with aes_gcm. Additionally it updates a few tests for clarity of what we are testing.
Finally, it simplifies the public api of FileEncryption. It removes the initialization vector and additional authenticated data from encrypt. This is to ensure compatibility with existing encrypted secrets already generated elsewhere. The initialization vector passed in was unused and it generated it's own internally.