Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rust-crypto crate #14

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Replace rust-crypto crate #14

merged 3 commits into from
Nov 16, 2022

Conversation

endoze
Copy link
Owner

@endoze endoze commented Nov 15, 2022

In order to ensure we are using up to date and maintained dependencies, this commit removes rust-crypto as it's no longer maintained and replaces it with aes_gcm. Additionally it updates a few tests for clarity of what we are testing.

Finally, it simplifies the public api of FileEncryption. It removes the initialization vector and additional authenticated data from encrypt. This is to ensure compatibility with existing encrypted secrets already generated elsewhere. The initialization vector passed in was unused and it generated it's own internally.

In order to ensure we are using up to date and maintained dependencies,
this commit removes rust-crypto as it's no longer maintained and
replaces it with aes_gcm. Additionally it updates a few tests for
clarity of what we are testing.

Finally, it simplifies the public api of FileEncryption. It removes the
initialization vector and additional authenticated data from encrypt.
This is to ensure compatibility with existing encrypted secrets already
generated elsewhere. The initialization vector passed in was unused and
it generated it's own internally.
This commit removes a println! statement from the
test_encryption_fails_with_non_hex_key test.
This commit changes some of the docs related to general usage of the
library.
@endoze endoze merged commit 1d94639 into master Nov 16, 2022
@endoze endoze deleted the replace-rust-crypto branch November 16, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant