feat: validate credential expiration #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichonien
requested review from
jrhender and
JGiter
and removed request for
jrhender
JGiter
reviewed
Jul 22, 2022
nichonien
force-pushed
the
task/EC-57_credential_expiration_date_validation
branch
from
7bd2299
to
ba302fb
Compare
nichonien
force-pushed
the
task/EC-57_credential_expiration_date_validation
branch
from
ba302fb
to
02559b5
Compare
jrhender
approved these changes
Jul 22, 2022
| return verificationResult(false, ERRORS.IssuerCredentialRevoked); | ||
| const revocationStatusResult = | ||
| await this.revocationVerification.checkRevocationStatus(issuer, role); | ||
| if (!revocationStatusResult.status) { |
There was a problem hiding this comment.
I find this line pretty confusing because I typically expect status to be an enum of some kind instead of a boolean (e.g. HTTP status code are are large list)
This is probably a different task, but what do you think of either:
- renaming
statustoverifiedand keeping it as a boolean - changing
statusto an enum of possible values (e.g.VERIFIED,NOT_VERIFIED) - or some other option
There was a problem hiding this comment.
Hmm, renaming it to verified sounds good. IMO boolean fits the return type and eases the validation upon it.
JGiter
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add validation for credential expiration for
RoleEIP191Jwt.