feat: make eip191JwtOf and credentialsOf public #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhender
previously approved these changes
Jul 28, 2022
nichonien
force-pushed
the
task/EC-62_make_credential_fetch_by_did_method_public
branch
from
ec86a77
to
4b035ef
Compare
JGiter
approved these changes
Jul 28, 2022
jrhender
approved these changes
Jul 28, 2022
| * @param did subject DID | ||
| * @returns RoleEIP191JWT list | ||
| */ | ||
| async eip191JwtOf(did: string): Promise<RoleEIP191JWT[]> { |
There was a problem hiding this comment.
Maybe consider adding an s here to indicate a plural return (as credentialsOf does)
Suggested change
| async eip191JwtOf(did: string): Promise<RoleEIP191JWT[]> { | |
| async eip191JwtsOf(did: string): Promise<RoleEIP191JWT[]> { |
nichonien
deleted the
task/EC-62_make_credential_fetch_by_did_method_public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.