Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storescp promiscuous mode #477

Closed
jennydaman opened this issue Mar 15, 2024 · 1 comment · Fixed by #500
Closed

Storescp promiscuous mode #477

jennydaman opened this issue Mar 15, 2024 · 1 comment · Fixed by #500
Labels
A-lib Area: library A-tool Area: tooling C-storescp Crate: dicom-storescp C-ul Crate: dicom-ul

Comments

@jennydaman
Copy link
Contributor

It is required to explicitly list all valid SOP class UIDs with ServerAssociationOptions::with_abstract_syntax. Would it be possible to support something similar to dcmtk storescp's "promiscuous" mode, so that unknown SOP classes are acceptable?

@Enet4 Enet4 added A-lib Area: library A-tool Area: tooling C-ul Crate: dicom-ul C-storescp Crate: dicom-storescp labels Mar 16, 2024
@Enet4
Copy link
Owner

Enet4 commented Mar 16, 2024

Yes, it makes sense to support promiscuous mode. This might be best implemented at dicom_ul::association::server, where the presentation context negotiation logic resides.
ServerAssociationOptions would have a promiscuous flag field, and the method establish would be tweaked to accept any abstract syntax (I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lib Area: library A-tool Area: tooling C-storescp Crate: dicom-storescp C-ul Crate: dicom-ul
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants