You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The attributes in the struct dicom_object::meta::FileMetaTable retain the padding from the encoded DICOM file meta group, and so they are usually padded for even length, even when built via the builder. While this makes it easy to serialize, it is not very useful when inspecting the attributes.
This calls for new methods to FileMetaTable which automatically trim the padding character out before returning the string slice.
Example signature (should be one per textual attribute):
Hi @Enet4 ,
I was browsing the good first issues to try to improve my Rust and dicom understanding when I saw this one.
When I went to the FileMetaTable methods, I could see that you added the getter in this commit and that it was merged.
So my question is the following, is it just that this issue should be closed or is there some more work I could help with ? If it's the case, could you provide a bit of guidance as to where I should start to handle this issue ?
@PierreBou91 You're right, I ended up adding these helper methods over time. Thanks for the heads up.
There are a few other issues with the good first issue label, such as #46, but if you are interested in tackling some other task recorded here, feel free to let me know through that issue or reach out to me on Zulip.
The attributes in the struct
dicom_object::meta::FileMetaTable
retain the padding from the encoded DICOM file meta group, and so they are usually padded for even length, even when built via the builder. While this makes it easy to serialize, it is not very useful when inspecting the attributes.This calls for new methods to
FileMetaTable
which automatically trim the padding character out before returning the string slice.Example signature (should be one per textual attribute):
The text was updated successfully, but these errors were encountered: