Morecmek #1450
Closed
Morecmek #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
- Coverage 17.2% 17.19% -0.01%
==========================================
Files 164 164
Lines 17104 17103 -1
==========================================
- Hits 2942 2941 -1
Misses 14162 14162
Continue to review full report at Codecov.
|
JoshDreamland
approved these changes
Dec 9, 2018
|
|
||
| // IDE_EDITABLEs added before compile | ||
| virtual int compile_parseAndLink(EnigmaStruct*,parsed_script*[], vector<parsed_script*>& tlines, const std::set<std::string>& script_names) = 0; | ||
| virtual int compile_parseSecondary(map<int,parsed_object*>&,parsed_script*[],int scrcount, vector<parsed_script*>& tlines, map<int,parsed_room*>&,parsed_object*, const std::set<std::string>&) = 0; | ||
| virtual int compile_parseAndLink(EnigmaStruct*, vector<parsed_script*>&, vector<parsed_script*>& tlines, const std::set<std::string>& script_names) = 0; |
There was a problem hiding this comment.
Prefer const& so it's clear nothing is being mutated (the stuff behind the pointers may be, but that's fine).
ghost
closed this
RobertBColton
added
Compile
| SOURCE_DIR "${CMAKE_SOURCE_DIR}/CompilerSource" | ||
| BINARY_DIR "${CMAKE_SOURCE_DIR}/build/compiler" | ||
| CMAKE_ARGS ${CL_ARGS} | ||
| ) |
There was a problem hiding this comment.
You're missing a newline here.
There was a problem hiding this comment.
this pr should be closed. idk y some idiot reopened it
|
Closing in favor of #1642 which was recreated from this. The branch can be deleted some period of time after this has been closed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.