Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Typescript 1.8 #4

Closed
MeirionHughes opened this issue Jun 13, 2016 · 5 comments
Closed

Update to Typescript 1.8 #4

MeirionHughes opened this issue Jun 13, 2016 · 5 comments
Assignees

Comments

@MeirionHughes
Copy link

MeirionHughes commented Jun 13, 2016

I quite like the look of this project; but it looks like it needs updating.

For example, with the latest TypeScript you can let the compiler deal with generating the definitions.

You can also use the "typings" field in package.json (point it to the typings definition), that way when people install your module via npm, typescript and IDE's can automatically pick up the typings without fanfare.

Should also have a dist folder containing the typescript compiled, at least, for system and commonjs module formats (with package.json pointing to the commonjs one. That way you can support node.js apps and browser-based apps (that use module loaders).

@ENikS
Copy link
Owner

ENikS commented Jun 13, 2016

Thank you for the suggestions. Will update it when time permits.
... or perhaps you could contribute changes?

@ENikS ENikS self-assigned this Jun 13, 2016
@MeirionHughes
Copy link
Author

yeah, I may do; I need a linq solution and I prefer your approach over others (working on-top of an iterator).

@et1975
Copy link

et1975 commented Jun 21, 2016

+1 for update.
TS noob here, went through the type imports, now can't figure why Array[T] can't be converted to Iterable or Enumerable...

@ENikS
Copy link
Owner

ENikS commented Jun 22, 2016

I am working on it. Stay tuned...

@ENikS
Copy link
Owner

ENikS commented Jun 24, 2016

  • The project is building with TSC 1.8.11
  • Added "typings" entry pointing to ling-xxx.d.ts
  • Compiled with option to generate UMD modules, should be good for node as well as browser
  • I've decided against allowing definition file to be generated by the TSC. The interface is governed by the C# implementation and should be source code compatible with the original. I think it is nice when you could just cut/paste code from C# (with reasonable formatting changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants