Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): angular support #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nebula2
Copy link

@nebula2 nebula2 commented Mar 3, 2024

Not an angular expert - but maybe this does the job for now. If not, it hopefully leads to some starting point.

Tested build and run - both work. Did not test with a configuration though - but should also work.

You must add angular to your run config In order to get this running (see RunConfiguration.cs).

image

Maybe Closes #2

@enisn
Copy link
Owner

enisn commented Mar 5, 2024

Thanks for your contribution, it seems perfect 👌

I'll try and merge asap

@enisn enisn self-requested a review March 5, 2024 06:30
@enisn
Copy link
Owner

enisn commented Mar 5, 2024

You seem like first-time contributor still, I think your email in git config doesn't match your github account email, probably you won't be listed as contributor by GitHub in the repository

image

Just an information, if you dont care about it, that's ok to me

@nebula2
Copy link
Author

nebula2 commented Mar 5, 2024

You seem like first-time contributor still, I think your email git config doesn't match your github account email, probably you won't be listed as contributor by GitHub in the repository

image

Just an information, if you dont care about it, that's ok to me

oops. thanks for telling me that. must have messed this up :-|

Copy link
Owner

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good but instead of using RunningCsProjItem, we can create another class for angular projects such as ``RunningPackageJsonItemorRunningAngularItem` etc.

Implementing all the logic in a single class increases maintaining cost, I'll implement add some other platform support here too (maui, mauiblazor, react native etc.) and they should be separated classes to manage easily

@nebula2
Copy link
Author

nebula2 commented Mar 6, 2024

Everything seems good but instead of using RunningCsProjItem, we can create another class for angular projects such as ``RunningPackageJsonItemorRunningAngularItem` etc.

Implementing all the logic in a single class increases maintaining cost, I'll implement add some other platform support here too (maui, mauiblazor, react native etc.) and they should be separated classes to manage easily

makes sense. I'll try to change that over the weekend :)

@nebula2
Copy link
Author

nebula2 commented Mar 31, 2024

Everything seems good but instead of using RunningCsProjItem, we can create another class for angular projects such as ``RunningPackageJsonItemorRunningAngularItem` etc.
Implementing all the logic in a single class increases maintaining cost, I'll implement add some other platform support here too (maui, mauiblazor, react native etc.) and they should be separated classes to manage easily

makes sense. I'll try to change that over the weekend :)

sry I am too busy at the moment with my business. I do not know when I find the time to implement this properly.
I'll finish it when I find a free spot - if it hasn't been done by someone else in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Support
2 participants