Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word wrapping for RadioButton and CheckBox #276

Closed
pikausp opened this issue Apr 11, 2023 · 7 comments
Closed

Word wrapping for RadioButton and CheckBox #276

pikausp opened this issue Apr 11, 2023 · 7 comments
Labels
bug Something isn't working control-checkbox external
Milestone

Comments

@pikausp
Copy link

pikausp commented Apr 11, 2023

When the text exceeds the screen width it gets clipped instead of being wrapped. I wasn't able to get it working.
image

When I was browsing the code in InputKit I found this remark which suggests there is a workaround needed but the text should wrap. Is that not the case? Am I doing something incorrectly?

Secondly, this comment proposes to use a two-column Grid to achieve the appropriate wrapping behavior. Reading the linked issue suggests that the HorizontalStackLayout behavior is desired and it won't be changed.

I'm using the controls from the Uranium.Material package so I posted in this repo instead of the InputKit one.

@enisn
Copy link
Owner

enisn commented Apr 11, 2023

Yeah, It's an MAUI Stacklayout issue and the issue (dotnet/maui#8873 (comment)) is still open.

I'll try to overcome this issue according to this comment

@pikausp
Copy link
Author

pikausp commented Apr 11, 2023

I tested the Grid solution and it seems to work without a problem. Do you have an idea about the vertical position of the CheckBox/RadioButton when text wrapping occurs? I could see an argument for both Center and Start (End not so much)

@pikausp
Copy link
Author

pikausp commented Apr 11, 2023

@enisn do you have any idea when you might be able to get to it? I'm more than happy to help with the implementation (the feature is quite important). Just given that the whole controls inherit from StatefulStackLayout I'm not sure about the approach you want to take.

@enisn
Copy link
Owner

enisn commented Apr 13, 2023

This issue should be fixed with a workaround with v2.3.3 release.

I'll refactor completely CheckBox in further feature releases

@enisn enisn added external bug Something isn't working control-checkbox labels Apr 13, 2023
@pikausp
Copy link
Author

pikausp commented Apr 13, 2023

There is still an issue with the width of the Label. I submitted an issue in the other repo with a PR proposal that would fix the issue and add further enhancements. So whenever you have time we can continue there :)

@pikausp
Copy link
Author

pikausp commented May 8, 2023

@enisn would you have a second to take a look at enisn/Xamarin.Forms.InputKit#348?

@enisn
Copy link
Owner

enisn commented May 9, 2023

Closed by enisn/Xamarin.Forms.InputKit#350

It'll be released in the next patch release of UraniumUI 2.4

Thanks @pikausp 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working control-checkbox external
Projects
None yet
Development

No branches or pull requests

2 participants