Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel 4.2 radiobutton checkbox enhancements #350

Merged

Conversation

pikausp
Copy link
Contributor

@pikausp pikausp commented May 9, 2023

This PR covers the proposals from #348 (comment) with the exception of FontFamily. I noticed the property was there already and I don't see a need for databinding.

I turned the Value property of RadioButton into bindable to make something like the following possible

<input:RadioButtonGroupView BindableLayout.ItemsSource="{Binding Items}"
                            BindableLayout.ItemTemplate="{StaticResource ItemTemplate}"
                            SelectedItem="{Binding SelectedItem, Mode=TwoWay}"/>

@enisn enisn self-requested a review May 9, 2023 10:59
@enisn enisn modified the milestones: v4.1, v4.2 May 9, 2023
@enisn
Copy link
Owner

enisn commented May 9, 2023

Perfectly done!

Thanks for your contribution 🎉

@enisn enisn merged commit 62d41d5 into enisn:rel-4.2 May 9, 2023
@pikausp pikausp deleted the rel-4.2-radiobutton-checkbox-enhancements branch May 9, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants